Aine Longcoats #59
Aine Longcoats #59
Conversation
github-actions
bot
added
Changes: Sprite
|
RSI Diff Bot; head commit e3a6d67 merging into 95a9304 Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatAL.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatBlack.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatBrigmedic.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatBrown.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatCC.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatCE.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatCMO.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatCap.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatHoP.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatHoS.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatLO.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatNT.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatRD.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatSec.rsi
Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/longcoatWarden.rsi
|
|
Before i do any changes, this PR feels its will fit better in upsteam: https://github.com/Simple-Station/Einstein-Engines/ I have run also the test and RSI seme angry, this will need fixes. |
|
And changlog will need to be different please. |
I won't lie, I have no idea what any of that or the other review stuff means yet, I have no idea what a fail means and I don't know if that's somehow something I added causing a break or something else. Changelog can be made real, I just had my brain in the wrong space as to what the changelog was referencing (updates to the pr rather than updates to the master) Probably could be done upstream but I don't need the anxiety of trying to publish something to a group that I don't know, to people that I don't have any real contact with yet or am comfortable asking for help, when I'm just figuring this stuff out. |
Resources/Prototypes/Catalog/VendingMachines/Inventories/clothesmate.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Catalog/VendingMachines/Inventories/detdrobe.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Catalog/VendingMachines/Inventories/sec.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Are the armor here normal? as if i remember we avoid to add armor mostly to civillians
There was a problem hiding this comment.
suggestions committed. For the armor values, I figured it'd be cute to have, but if it's a problem, I don't mind removing those values entirely.
I do wana note that upsteam is not wizden but upsteam. |
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
…esmate.yml Co-authored-by: FoxxoTrystan <[email protected]>
…obe.yml Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
I know it's not wizden, but otherwise this... just confused me. Is upstream not what we call the EE code/team, because That's what I was referring to when I meant people I don't know. |
|
RSI / Linter test failed, click details and fix the issues displayed. |
|
I really like this. We can merge this upstream if need be that shouldn't be a problem. |
|
RSI: YAML Linter: Check failed tests for more information. If your unable to do the fixes yourself i can do it myself if you wish. |
|
RSI/YAML fixed, I believe. Got to love all that angry error text just for a simple filename capitalization goof. Edit: Nevermiiind it was showing me green until it failed... |
There was a problem hiding this comment.
Linter still uhappy:
Error: /Prototypes/Catalog/VendingMachines/Inventories/clothesmate.yml(98,5) PrototypeID ClothingLongcoatNT for type Robust.Shared.Prototypes.EntityPrototype at Line: 98, Col: 5 not found
Error: /Prototypes/Catalog/VendingMachines/Inventories/clothesmate.yml(99,5) PrototypeID ClothingLongcoatAL for type Robust.Shared.Prototypes.EntityPrototype at Line: 99, Col: 5 not foun
Yeah because its your first PR here, i have to aprove the tests myself. |
|
Should be good now, LongcoatNT and LongcoatAL were newer names before that the files got but the prototype didn't. |
Description
Double-breasted longcoats for almost everyone! Includes one for each unit of Command, three for Security Staff (Corpsman, Warden, Secoff), and four general-purpose ones (Brown, Black, Nanotrasen and an Arashi Labs 'medical' colored one, and of course a green version of the Captain's for Central Command.
Command, Corpsman and Warden Longcoats are added to their respective lockers. The basic Armored Longcoat has two copies in the SecTech between the Durathread Vest and Plate Carrier (as it is statistically analagous to them) while the four general longcoats are in the ClothesMate.
Designs are in media.
TODO
Add at least the general longcoats to loadouts.
Possibly add Corporate Jacket versions, need to discuss item bloat at some point as adding a dozen jackets into the ClothesMate is going to make that list very, very long...
Media
Changelog
🆑
4 Common ones found in the clothesmate, Brown, Black, Nanotrasen, and an Arashi Labs 'medical cyan' one.
4 Armored Sec ones, with Secoff Armored coats available in the SecTech and unique ones found in HoS, Brigmedic and Warden lockers, Detective vendor has a copy of the Armored longcoat as well as an unarmored Brown longcoat
7 Command-colored ones to match their respective Cloaks: Captain, HoP, LO, RD, CMO, CE all have theirs available in their locker, and a Central Command one for admins.